Druva-D commented on code in PR #20268:
URL: https://github.com/apache/datafusion/pull/20268#discussion_r3145117867
##########
datafusion/spark/src/function/string/format_string.rs:
##########
@@ -2082,6 +2085,10 @@ impl ConversionSpecifier {
}
};
+ if self.grouping_separator {
+ number = insert_thousands_separator(&number);
+ }
Review Comment:
Yeah it does, will move it to only apply on non scientific output
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
