Jefffrey commented on issue #15914: URL: https://github.com/apache/datafusion/issues/15914#issuecomment-4326363559
> However keeping simplify might help with the spark expr users directly from DF though ? (Not sure if I am missing something here) Usually for UDFs that implement simplify we omit the implementation of invoke. See an example here: https://github.com/apache/datafusion/blob/1897c281139b7b33875f36e18bd2dd5565dcaee1/datafusion/spark/src/function/datetime/unix.rs#L147-L164 I think we prefer not having both simplify and invoke implemented if simplify is unconditional (always will rewrite) since we don't want to maintain both paths, and potentially worry about any edge cases that might occur on one path but not another. (There are some simplifys which only invoke under certain conditions so there is still an accompanying invoke, but I don't think we have an example of that under datafusion-spark yet) - An example of this is log/power in datafusion-functions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
