Jefffrey commented on issue #15914: URL: https://github.com/apache/datafusion/issues/15914#issuecomment-4324008673
Something that's been in the back of my mind for a while now is if we should set some guidelines on some implementation details for these functions. For example, should we avoid implementing `simplify` for these UDFs as I believe comet wouldn't be able to benefit from that? And should we make it explicit that the signature/invoke code don't need to include datatypes not supported by Spark like unsigned integers, decimals other than decimal128, float16, etc.? Would be good to have some thoughts on these (and any other gotchas) and perhaps include them into the README if we need to set guidelines 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
