jayshrivastava commented on code in PR #21807:
URL: https://github.com/apache/datafusion/pull/21807#discussion_r3139711792
##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -495,9 +377,67 @@ impl DynamicFilterPhysicalExpr {
}
/// Generate a new expression id for this filter.
- pub fn new_expression_id() -> u64 {
+ fn new_expression_id() -> u64 {
random::<u64>()
}
+
+ /// Return the filter's original children (before any remapping).
+ pub fn original_children(&self) -> &[Arc<dyn PhysicalExpr>] {
+ &self.children
+ }
+
+ /// Return the filter's remapped children, if any have been set via
+ /// [`PhysicalExpr::with_new_children`].
+ pub fn remapped_children(&self) -> Option<&[Arc<dyn PhysicalExpr>]> {
+ self.remapped_children.as_deref()
+ }
Review Comment:
These two getters aren't horrible to keep around, so I didn't mark them as
unstable. Lmk if you think we should add
```
/// **Warning:** intended only for `datafusion-proto` (de)serialization.
/// Not a stable API
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
