jayshrivastava commented on code in PR #21807:
URL: https://github.com/apache/datafusion/pull/21807#discussion_r3134571155
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -3839,85 +3836,16 @@ impl PhysicalProtoConverterExtension for
DefaultPhysicalProtoConverter {
}
}
-/// Internal serializer that adds expr_id to expressions.
-/// Created fresh for each serialization operation.
-struct DeduplicatingSerializer {
Review Comment:
Since the DynamicFilterPhysicalExpr self-generates an expr id and exposes it
via expression_id, we don't need this anymore. We can just dedupe during
deserialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
