karuppayya commented on PR #3895: URL: https://github.com/apache/datafusion-comet/pull/3895#issuecomment-4315047260
> Fix: treat null scheme as unsupported so these scans fall back. Rejecting scheme == null also blocks HadoopCatalog local paths (e.g. /tmp/warehouse/...) which have no URI scheme — this caused all CometIcebergNativeSuite tests to fail again. Instead, added an explicit FileIO type check. (REST catalogs are unaffected(mentioned in the code comment) since the client-side table uses ResolvingFileIO, not InMemoryFileIO (see [RESTSessionCatalog.DEFAULT_FILE_IO_IMPL](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L117))) Also added `countDeletes() = false` override in the Iceberg diffs for 3.5 (present already for 3.5) since iceberg-rust doesn't expose the delete count metric. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
