andygrove commented on code in PR #4057:
URL: https://github.com/apache/datafusion-comet/pull/4057#discussion_r3138828575
##########
docs/source/contributor-guide/adding_a_new_expression.md:
##########
@@ -70,10 +70,12 @@ object CometUnhex extends CometExpressionSerde[Unhex] {
}
```
-The `CometExpressionSerde` trait provides three methods you can override:
+The `CometExpressionSerde` trait provides several methods you can override:
- `convert(expr: T, inputs: Seq[Attribute], binding: Boolean): Option[Expr]` -
**Required**. Converts the Spark expression to protobuf. Return `None` if the
expression cannot be converted.
-- `getSupportLevel(expr: T): SupportLevel` - Optional. Returns the level of
support for the expression. See "Using getSupportLevel" section below for
details.
+- `getSupportLevel(expr: T): SupportLevel` - Optional. Returns the level of
support for the expression at planning time, based on a specific expression
instance. See "Using getSupportLevel" section below for details.
Review Comment:
addressed in https://github.com/apache/datafusion-comet/pull/4067
##########
docs/source/contributor-guide/adding_a_new_expression.md:
##########
@@ -70,10 +70,12 @@ object CometUnhex extends CometExpressionSerde[Unhex] {
}
```
-The `CometExpressionSerde` trait provides three methods you can override:
+The `CometExpressionSerde` trait provides several methods you can override:
- `convert(expr: T, inputs: Seq[Attribute], binding: Boolean): Option[Expr]` -
**Required**. Converts the Spark expression to protobuf. Return `None` if the
expression cannot be converted.
-- `getSupportLevel(expr: T): SupportLevel` - Optional. Returns the level of
support for the expression. See "Using getSupportLevel" section below for
details.
+- `getSupportLevel(expr: T): SupportLevel` - Optional. Returns the level of
support for the expression at planning time, based on a specific expression
instance. See "Using getSupportLevel" section below for details.
+- `getIncompatibleReasons(): Seq[String]` - Optional. Returns reasons why this
expression may produce different results than Spark. Used to generate the
Compatibility Guide. See "Documenting Incompatible and Unsupported Reasons"
below.
+- `getUnsupportedReasons(): Seq[String]` - Optional. Returns reasons why this
expression may not be supported by Comet (for example, unsupported data types
or format strings). Used to generate the Compatibility Guide. See "Documenting
Incompatible and Unsupported Reasons" below.
Review Comment:
addressed in https://github.com/apache/datafusion-comet/pull/4067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
