andygrove opened a new pull request, #4057: URL: https://github.com/apache/datafusion-comet/pull/4057
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Part of https://github.com/apache/datafusion-comet/issues/4050 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> We currently have a manual process where we try and keep documentation up to date with the implementation for expressions. In the code, we have `getSupportLevel` and `convert` where we have the logic for fallback reasons. In docs, we have the expression list as well as the compatibility guide where we document some of this, but it is often not kept up to date as code changes. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> This PR adds two new methods to `ExpressionSerde` trait: - `getIncompatibleReasons` - `getUnsupportedReasons` *WIP* The plan is to update `GenerateDocs` to call these methods and write the reasons to the docs so that we no longer have to maintain this by hand. Note that we still have to make sure that these methods are kept in sync with `getSupportLevel`, but they are next to each other in the code (or should be) so it seems like an easier process. ## How are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
