iffyio commented on code in PR #2309:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2309#discussion_r3137548787
##########
tests/sqlparser_mysql.rs:
##########
@@ -4891,3 +4891,9 @@ fn parse_create_database_with_charset_option_ordering() {
"CREATE DATABASE mydb DEFAULT CHARACTER SET utf8mb4 DEFAULT COLLATE
utf8mb4_unicode_ci",
);
}
+
Review Comment:
ah right that wasnt clear in the PR, the issue was that this statement in
the common test `SELECT 'M' "y" 'S' "q" 'l'"` only works on mysql, because it
involves the string concat feature, but also that the dialect supports `"y"` as
a string character instead of an identifier which only mysql does. So the
statement was rewritten to single quotes to remain in common, but also moved
here so that the double quote behavior is still covered for mysql
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
