yoavcloud commented on code in PR #2309:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2309#discussion_r3137151502
##########
tests/sqlparser_mysql.rs:
##########
@@ -4891,3 +4891,9 @@ fn parse_create_database_with_charset_option_ordering() {
"CREATE DATABASE mydb DEFAULT CHARACTER SET utf8mb4 DEFAULT COLLATE
utf8mb4_unicode_ci",
);
}
+
Review Comment:
Curious as to why you add this test explicitly for MySQL, given the test
already exists in common?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
