neilconway commented on code in PR #21789:
URL: https://github.com/apache/datafusion/pull/21789#discussion_r3131975433
##########
datafusion/functions/src/string/common.rs:
##########
@@ -399,18 +410,28 @@ where
// Values contain non-ASCII.
let item_len = string_array.len();
- let capacity = string_array.value_data().len() + PRE_ALLOC_BYTES;
- let mut builder = GenericStringBuilder::<O>::with_capacity(item_len,
capacity);
+ let capacity = value_data.len() + PRE_ALLOC_BYTES;
+ let nulls = string_array.nulls().cloned();
Review Comment:
Thanks, I added some comments to clarify this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
