neilconway commented on PR #21789: URL: https://github.com/apache/datafusion/pull/21789#issuecomment-4304556093
Thanks for the review @EeshanBembi ! > Nit: consider exposing an `append_null()` alias alongside `append_placeholder()`. I don't agree with adding an alias; I'd prefer to pick one name or the other. `append_null` is what `StringBuilder` in Arrow does, but the semantics are a little different there -- in that case, `append_null` is *all* you need to do to append a null value. In this case, calling `append_placeholder` isn't sufficient to add a NULL row; you also need to pass a NULL bitmap with the corresponding bit set. I think using a name other than `append_null` makes this a bit more clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
