Jefffrey commented on PR #21262: URL: https://github.com/apache/datafusion/pull/21262#issuecomment-4303398429
That could be a way forward, but I think we could potentially still run into edge cases such as: 1. register `to_char()` (has alias `date_format`) 1. register `to_character()` (has alias `to_char`) 1. register `to_string()` (has alias `to_character`) This leaves us in a state where only `to_string()` keeps its canonical mapping, and `to_character()` survives via its alias `to_char` and `to_char()` survives via `date_format`. So now we could have a race based on if `to_character()` or `to_char()` gets registered first in the roundtrip. Perhaps the current data structure of `SessionStateBuilder` is incompatible of doing a pure roundtrip, unless we can somehow record the order in which UDFs were recorded in the original `SessionState`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
