Jefffrey commented on PR #21262:
URL: https://github.com/apache/datafusion/pull/21262#issuecomment-4273032887
Thanks for the example. I was able to reproduce it via modifying the test
included here to have two registered UDFs as described. It would be good to
enhance the test introduced here to clearly reproduce the error (even if it
happens randomly).
> With these changes, the filter key.as_str() == udf.name() only keeps
entries where the HashMap key is the UDF's canonical name. This drops the
built-in because its canonical key ("to_char") was overwritten by the custom
UDF; it only exists under "date_format", which doesn't match its canonical name
"to_char". So the built-in is never passed to build(), and the custom UDF's
override is preserved.
Is this dropping of `date_format` intentional? It doesn't seem ideal since
the roundtripped session state will now be different from the original.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
