sgrebnov commented on PR #21744: URL: https://github.com/apache/datafusion/pull/21744#issuecomment-4302624831
> LGTM, would be better if there are some slt tests @xudong963 — There's an existing SLT test ([sort_pushdown.slt Test 1.3](https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/sort_pushdown.slt#L57-L65)) that already covers the Exact pushdown + LIMIT case where the source supports `with_fetch()`. The specific fallback path this PR fixes (`GlobalLimitExec`/`LocalLimitExec` wrapping when the source doesn't support `with_fetch()`) can't be triggered through SLT because all built-in data sources support `with_fetch()`. Adding a custom test-only table provider to the SLT harness just for this seems like overkill, so I'd propose keeping the unit tests with the configurable `TestScan`. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
