timsaucer commented on code in PR #21030: URL: https://github.com/apache/datafusion/pull/21030#discussion_r3124106162
########## datafusion/ffi/README.md: ########## @@ -65,7 +65,7 @@ to work across Rust libraries. In general, you can use Rust's [FFI] to operate across different programming languages, but that is not the design intent of this crate. Instead, we are using external crates that provide stable interfaces that closely mirror the Rust native approach. To learn more -about this approach see the [abi_stable] and [async-ffi] crates. +about this approach see the [stabby] and [async-ffi] crates. If you have a library in another language that you wish to interface to DataFusion the recommendation is to create a Rust wrapper crate to interface Review Comment: For users who are interested in working on this code, they will probably ask themselves the same thing I asked. Why is it we are not using the core features of stabby? You and I have both come to the same conclusion that especially with the work on getting the record batch stream converted over to using stabby it turns into a much different project, especially when it comes to build times with the heavy macro use. I think we just need some documentation as mentioned in a prior comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
