hcrosse commented on PR #21689: URL: https://github.com/apache/datafusion/pull/21689#issuecomment-4299742932
> Sorry folks, I still not very confident with this change. > > ... > > My understanding the implementation should be pretty straightforward, just delegate the call to array_concat if incoming arguments for `concat` are lists, however there is a fundamental issue with dependencies, namely: > > The problem: `ConcatFunc` (string) and `ArrayConcat` live in separate crates with a one-way dependency (functions-nested → functions), so adding a reverse dependency would be circular. That means `ConcatFunc::invoke_with_args` can't call `array_concat_inner` directly. > > I think we need to investigate how to overcome this issue. Yeah that's fair. I think that call probably takes more familiarity with the project than I currently have, so it might be best to close this PR for now. I'll take a look at implementing the list parts of https://github.com/apache/arrow-rs/issues/1772 in the meantime - if I can land that in a reasonable timeframe it may be the cleanest solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
