gstvg commented on PR #21679: URL: https://github.com/apache/datafusion/pull/21679#issuecomment-4294596087
I pushed the branch with array_reduce without explicit casts: [sqllogictests. Note that the initial_value is not of the exact type and casts gets automatically added](https://github.com/gstvg/arrow-datafusion/blob/1a453c9699007d625fa8c3b8488e16b5c5789df0/datafusion/sqllogictest/test_files/higher_order.slt#L215-L252) [green cargo test amd64 CI run](https://github.com/gstvg/arrow-datafusion/actions/runs/24765451384/job/72459269437) [full commit (lacks comments and some error handling, docs not updated)](https://github.com/gstvg/arrow-datafusion/commit/1a453c9699007d625fa8c3b8488e16b5c5789df0) The `lambda_parameters` signature is the same as my [previous comment](https://github.com/apache/datafusion/pull/21679#issuecomment-4286551740) I used a fairly limited array_reduce with support for fixed size lists only directly in sqllogictests crate. Should it be included in this PR only to test and make sure this kind of function is supported? It wouldn't be available to extern usage. Or array_transform is enough? My bad for not addressing the reviews yet, I will do that tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
