comphead commented on PR #21075: URL: https://github.com/apache/datafusion/pull/21075#issuecomment-4292601093
Agree, it is good there are no performance regressions. Let me go through it one final time. Another thing: let's have the rule disabled by default to avoid optimization false positives, and potential user query degradation. We would need to add description of this change to `Upgrade guide` for DataFusion 54.0.0 release. So the users would know what is this rule, how it works, and for what type of queries it is reasonable to enable the rule config. Generally speaking, going forward we need to document optimization rules and technics in a separate doc, so the users are able to check all optimization rules DataFusion is capable of and also how and when to use/enable/disable rules -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
