xiedeyantu commented on PR #21075: URL: https://github.com/apache/datafusion/pull/21075#issuecomment-4292373687
> @xiedeyantu just started the benches > > bench results are prone to some kind of noise, so usually 1.0x in any direction is considered to be noise. Looking at the results, they are pretty neutral, are you expecting this optimization to boost a query from TPC* set, like TPCDS Q3 or TPCH Q7 might look like a candidate? I think neither TPC-DS nor TPC-H may have SQL queries suitable for this specific rule. As long as the rule doesn't slow down the query planning of other SQL in the tests, that should be acceptable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
