2010YOUY01 commented on code in PR #21738:
URL: https://github.com/apache/datafusion/pull/21738#discussion_r3115955826
##########
datafusion/physical-plan/src/spill/mod.rs:
##########
@@ -130,6 +131,21 @@ impl SpillReaderStream {
StreamReader::try_new(file,
None)?.with_skip_validation(true)
};
+ // Validate the schema read from Arrow IPC file is the
same as the
+ // schema of the current `SpillManager`
+ let actual_schema = reader.schema();
+
+ if actual_schema != expected_schema {
Review Comment:
Good point. I’m not sure—some metadata may need to be preserved through the
round trip.
What do you think about keeping the metadata comparison for now to stay
conservative? If it proves unnecessarily strict later, we can relax it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
