2010YOUY01 opened a new pull request, #21738:
URL: https://github.com/apache/datafusion/pull/21738
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Follow-up to a review comment in :
https://github.com/apache/datafusion/pull/21713#discussion_r3105683963
Not a bug fix, this PR tries to be more defensive and catch potential bugs.
Before, when you write a spill file from a `SpillManager`, then read with
another `SpillManager` of different schema, it would succeed. This is not a
expected use pattern, an error will get propagated to the caller, and become
harder to debug.
This PR validates the schema when reading the first batch, and fail fast if
the schema does not match.
Note it only validates the schema, if two `SpillManager`s with the same
schema do read and write, it's still allowed, but this is not a expected use
pattern. Validating this case requires assigning `SpillManager` UID, and add
that to the Arrow IPC file metadata, can be tricky, so leave this as TODO for
simplicity.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
UTs
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
