SubhamSinghal commented on code in PR #21479:
URL: https://github.com/apache/datafusion/pull/21479#discussion_r3068983871
##########
datafusion/physical-optimizer/src/optimizer.rs:
##########
@@ -125,6 +126,11 @@ impl PhysicalOptimizer {
Arc::new(EnforceSorting::new()),
// Run once after the local sorting requirement is changed
Arc::new(OptimizeAggregateOrder::new()),
+ // WindowTopN: replaces Filter(rn<=K) → Window(ROW_NUMBER) → Sort
+ // with Window(ROW_NUMBER) → PartitionedTopKExec(fetch=K).
+ // Must run after EnforceSorting (which inserts SortExec) and
before
Review Comment:
Will try it out in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
