asolimando commented on PR #21473: URL: https://github.com/apache/datafusion/pull/21473#issuecomment-4214938482
Thanks @buraksenn for tackling both #21109 and #21111 together with this type-agnostic approach, also the test consolidation over the separate per-type functions is a nice improvement. A couple of minor notes/questions: - Since we can't rely on interval analysis for string-based columns, I am not sure we handle correctly "contradictory" filters like `name = 'alice' AND name = 'bob'`, which should get `Exact(0)` as happening for numeric types. I don't see this as a blocker because it's not worse than before and this is an edge case, but it's good to know where we stand and file a follow-up issue, if needed. - On a similar note, I was wondering if something like `col = NULL` gets simplified as `false` (under the unknown as false semantics for predicates in `WHERE` clauses). In case it doesn't, it would be worth adding a test making sure we don't set NDV to 1. - Did you manage to understand why the interval analysis doesn't seem to work as expected for temporal types? It might be worth filing a separate issue for that if you have bandwidth, so we don't lose track of this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
