asolimando commented on code in PR #21122:
URL: https://github.com/apache/datafusion/pull/21122#discussion_r3053877511
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -2898,7 +2920,11 @@ impl DefaultPhysicalPlanner {
.into_iter()
.map(|(expr, alias)| ProjectionExpr { expr, alias })
.collect();
- Ok(Arc::new(ProjectionExec::try_new(proj_exprs, input_exec)?))
+ let mut proj_exec = ProjectionExec::try_new(proj_exprs,
input_exec)?;
Review Comment:
Thanks for your guidance, @kosiew!
I have implemented option 1 optimistically in 54a0df74: tightened the config
description and doc comments to make the scope explicit. But we can drop it in
case option 2 is finally retained.
For option 2, I have opened #21483 (it was originally stacked on this PR,
but I have reworked it to make it independent, the two can be composed later if
#21483 gets in first) if you want to take a concrete look to evaluate whether
you'd prefer to hold this PR until that one is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
