zhuqi-lucas commented on PR #21182: URL: https://github.com/apache/datafusion/pull/21182#issuecomment-4182432337
Updated, i changed the buffer size to 16 instead of 32, and it's perfect now, no regression for other benchmark, and our PR make it faster: ```rust Comparing HEAD and feat_sort-file-groups-by-statistics -------------------- Benchmark sort_pushdown_sorted.json -------------------- ┏━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ HEAD ┃ feat_sort-file-groups-by-statistics ┃ Change ┃ ┡━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ Q1 │ 157.96 / 159.09 ±0.79 / 160.06 ms │ 118.04 / 118.75 ±0.56 / 119.42 ms │ +1.34x faster │ │ Q2 │ 12.75 / 12.87 ±0.10 / 13.03 ms │ 2.57 / 2.79 ±0.29 / 3.36 ms │ +4.61x faster │ │ Q3 │ 366.58 / 367.64 ±1.07 / 369.19 ms │ 387.44 / 389.31 ±1.66 / 392.41 ms │ 1.06x slower │ │ Q4 │ 53.18 / 54.29 ±1.09 / 56.13 ms │ 5.70 / 6.27 ±0.59 / 7.26 ms │ +8.65x faster │ └───────┴───────────────────────────────────┴─────────────────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩ │ Total Time (HEAD) │ 593.88ms │ │ Total Time (feat_sort-file-groups-by-statistics) │ 517.12ms │ │ Average Time (HEAD) │ 148.47ms │ │ Average Time (feat_sort-file-groups-by-statistics) │ 129.28ms │ │ Queries Faster │ 3 │ │ Queries Slower │ 1 │ │ Queries with No Change │ 0 │ │ Queries with Failure │ 0 │ └────────────────────────────────────────────────────┴──────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
