jonahgao commented on code in PR #21287: URL: https://github.com/apache/datafusion/pull/21287#discussion_r3031108838
########## Cargo.toml: ########## @@ -212,6 +212,9 @@ needless_pass_by_value = "warn" # https://github.com/apache/datafusion/issues/18881 allow_attributes = "warn" assigning_clones = "warn" +# ScalarValue and Expr contain Arc<..> with interior mutability but are +# intentionally used as hash keys throughout the codebase. +mutable_key_type = "allow" Review Comment: Is there any chance we can allow this lint only for Expr and ScalarValue🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
