viirya commented on code in PR #3876:
URL: https://github.com/apache/datafusion-comet/pull/3876#discussion_r3030917285
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometWindowExec.scala:
##########
@@ -72,7 +72,12 @@ object CometWindowExec extends
CometOperatorSerde[WindowExec] {
return None
}
- if (op.partitionSpec.nonEmpty && op.orderSpec.nonEmpty &&
+ // Offset window functions (LAG, LEAD) support arbitrary partition and
order specs, so skip
Review Comment:
No, in Spark
Lag / Lead → inherit FrameLessOffsetWindowFunction
NthValue → inherit AggregateWindowFunction with OffsetWindowFunction
First / Last → inherit DeclarativeAggregate
Only FrameLessOffsetWindowFunction doesn't require frame, currently in Spark
only Lag / Lead are FrameLessOffsetWindowFunction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
