andygrove commented on code in PR #3876:
URL: https://github.com/apache/datafusion-comet/pull/3876#discussion_r3028325752
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometWindowExec.scala:
##########
@@ -141,12 +143,21 @@ object CometWindowExec extends
CometOperatorSerde[WindowExec] {
}
}.toArray
- val (aggExpr, builtinFunc) = if (aggregateExpressions.nonEmpty) {
+ val (aggExpr, builtinFunc, ignoreNulls) = if
(aggregateExpressions.nonEmpty) {
val modes = aggregateExpressions.map(_.mode).distinct
assert(modes.size == 1 && modes.head == Complete)
- (aggExprToProto(aggregateExpressions.head, output, true, conf), None)
+ (aggExprToProto(aggregateExpressions.head, output, true, conf), None,
false)
} else {
- (None, exprToProto(windowExpr.windowFunction, output))
+ windowExpr.windowFunction match {
+ case lag: Lag =>
Review Comment:
Should `Lead` also be handled the same way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
