buraksenn commented on PR #21082: URL: https://github.com/apache/datafusion/pull/21082#issuecomment-4178598612
> lgtm, thanks @buraksenn > > Might be worth double-checking a couple of things: > > 1. `current_time()`: Europe/London in December should be UTC+0, so the +1h offset might not hold, so it could be worth picking a timezone with a clear winter offset. > > 2. now(): the "Z" suffix after switching to America/New_York might be incorrect since "Z" means UTC, but the return type carries the session timezone. Might want to run it locally to confirm what actually gets printed I've run the cli and verified each now. There was some mistakes thanks @berkaysynnada -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
