alamb commented on issue #21165: URL: https://github.com/apache/datafusion/issues/21165#issuecomment-4154394698
> Bringing my comment from [#21184](https://github.com/apache/datafusion/pull/21184): > > > Also I'm now confused where I should add benchmarks. [#20464](https://github.com/apache/datafusion/pull/20464) added Criterion SMJ benchmarks for sort-merge join , but it's missing scenarios from dfbench's smj benchmarks, which I further extend here. Any help? > > Each PR I work on SMJ I add more benchmarks to represent problem scenarios we're seeing. But after [#20464](https://github.com/apache/datafusion/pull/20464) I am now confused. Where should I be adding benchmarks, and what will we be using to catch regressions? Yeah, I think this is a great point -- it is not easy to add new benchmarks to the existing runner infrastructure, so it doesn't get done often -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
