alamb commented on code in PR #6257:
URL: https://github.com/apache/arrow-rs/pull/6257#discussion_r1720755309
##########
parquet/src/arrow/arrow_reader/statistics.rs:
##########
@@ -1195,6 +1197,23 @@ impl<'a> StatisticsConverter<'a> {
self.arrow_field
}
+ /// Set the statistics converter to treat missing null counts as missing
Review Comment:
> The default in this PR is missing_null_counts_as_zero = true, which
maintains the old behavior, right?
Yes
> then I would expect the default to be the new behavior.
My thinking was
Since there are two different apis:
`Statistics::null_count` would now return `Option<..>` so users of the
library will ned to update their code anyways and thus can choose at that time
which behavior they wanted
`StatisticsConverter`'s API didn't change and thus it keeps the previous
behavior. This is what I would persoanlly want for a system -- no change for
reading parquet files that were written with previous versions of the rust
writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
