alamb commented on code in PR #6257:
URL: https://github.com/apache/arrow-rs/pull/6257#discussion_r1718827728
##########
parquet/src/file/statistics.rs:
##########
@@ -1041,4 +1066,91 @@ mod tests {
true,
));
}
+
+ #[test]
+ fn test_count_encoding() {
+ statistics_count_test(None, None);
Review Comment:
This test fails like this without the changes in this PR:
```
assertion `left == right` failed
left: Boolean({min: Some(true), max: Some(false), distinct_count: None,
null_count: Some(0), ...
right: Boolean({min: Some(true), max: Some(false), distinct_count: None,
null_count: None, ...
```
##########
parquet/tests/arrow_writer_layout.rs:
##########
@@ -189,7 +189,7 @@ fn test_primitive() {
pages: (0..8)
.map(|_| Page {
rows: 250,
- page_header_size: 36,
+ page_header_size: 38,
Review Comment:
The page headers (and files) are larger now because `Some(0)` takes more
space than `None`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
