kasakrisz commented on code in PR #6391:
URL: https://github.com/apache/hive/pull/6391#discussion_r3019742438
##########
ql/src/test/queries/clientpositive/drop_histogram_stats_for_columns.q:
##########
@@ -0,0 +1,29 @@
+set hive.stats.kll.enable=true;
+set metastore.stats.fetch.bitvector=true;
+set metastore.stats.fetch.kll=true;
+set hive.stats.autogather=true;
+set hive.stats.column.autogather=true;
+
+CREATE TABLE test_stats (a string, b int, c double) STORED AS ORC;
+
+insert into test_stats (a, b, c) values ("a", 2, 1.1);
+insert into test_stats (a, b, c) values ("b", 2, 2.1);
+insert into test_stats (a, b, c) values ("c", 2, 2.1);
+insert into test_stats (a, b, c) values ("d", 2, 3.1);
+insert into test_stats (a, b, c) values ("e", 2, 3.1);
+insert into test_stats (a, b, c) values ("f", 2, 4.1);
+insert into test_stats (a, b, c) values ("g", 2, 5.1);
+insert into test_stats (a, b, c) values ("h", 2, 6.1);
+insert into test_stats (a, b, c) values ("i", 3, 6.1);
Review Comment:
IMHO, if the test doesn't depend on the stats, then inserting more values
than necessary just adds extra complexity and wastes resources. (insert is
expensive).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
