soumyakanti3578 commented on code in PR #6391:
URL: https://github.com/apache/hive/pull/6391#discussion_r3018907928


##########
ql/src/test/queries/clientpositive/drop_histogram_stats_for_columns.q:
##########
@@ -0,0 +1,29 @@
+set hive.stats.kll.enable=true;
+set metastore.stats.fetch.bitvector=true;
+set metastore.stats.fetch.kll=true;
+set hive.stats.autogather=true;
+set hive.stats.column.autogather=true;
+
+CREATE TABLE test_stats (a string, b int, c double) STORED AS ORC;
+
+insert into test_stats (a, b, c) values ("a", 2, 1.1);
+insert into test_stats (a, b, c) values ("b", 2, 2.1);
+insert into test_stats (a, b, c) values ("c", 2, 2.1);
+insert into test_stats (a, b, c) values ("d", 2, 3.1);
+insert into test_stats (a, b, c) values ("e", 2, 3.1);
+insert into test_stats (a, b, c) values ("f", 2, 4.1);
+insert into test_stats (a, b, c) values ("g", 2, 5.1);
+insert into test_stats (a, b, c) values ("h", 2, 6.1);
+insert into test_stats (a, b, c) values ("i", 3, 6.1);

Review Comment:
   I don't think it is dependent on the specific value of stats at all. The 
tests run these:
   
   1. create table
   2. insert values with autogather on so that stats are computed
   3. describe formatted tables and columns to check that 
`COLUMN_STATS_ACCURATE` is true for table and all columns
   4. alter table drop statistics for all columns;
   5. describe formatted tables and columns to check that 
`COLUMN_STATS_ACCURATE` is true only for table (basic stats)
   
   The test before my last commit was fine too but I thought it's not bad to 
add more variance for the column although it didn't affect the test at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to