Aggarwal-Raghav commented on code in PR #6390:
URL: https://github.com/apache/hive/pull/6390#discussion_r3005036643
##########
packaging/src/docker/entrypoint.sh:
##########
@@ -67,6 +71,62 @@ function initialize_hive {
fi
}
+function run_llap {
+ : "${HIVE_ZOOKEEPER_QUORUM:=zookeeper:2181}"
+ : "${LLAP_SERVICE_HOSTS:=@llap0}"
+ : "${LLAP_MEMORY_MB:=1024}"
+ : "${LLAP_EXECUTORS:=1}"
+ export HIVE_ZOOKEEPER_QUORUM
Review Comment:
nit, the export can be combined as done for L86-94:
```
export HIVE_ZOOKEEPER_QUORUM="${HIVE_ZOOKEEPER_QUORUM:-zookeeper:2181}"
export LLAP_SERVICE_HOSTS="${LLAP_SERVICE_HOSTS:-@llap0}"
export LLAP_MEMORY_MB="${LLAP_MEMORY_MB:-1024}"
export LLAP_EXECUTORS="${LLAP_EXECUTORS:-1}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
