Aggarwal-Raghav commented on code in PR #6390:
URL: https://github.com/apache/hive/pull/6390#discussion_r3005035769
##########
packaging/src/docker/entrypoint.sh:
##########
@@ -67,6 +71,62 @@ function initialize_hive {
fi
}
+function run_llap {
+ : "${HIVE_ZOOKEEPER_QUORUM:=zookeeper:2181}"
+ : "${LLAP_SERVICE_HOSTS:=@llap0}"
+ : "${LLAP_MEMORY_MB:=1024}"
+ : "${LLAP_EXECUTORS:=1}"
+ export HIVE_ZOOKEEPER_QUORUM
+ export LLAP_SERVICE_HOSTS
+ export LLAP_MEMORY_MB
+ export LLAP_EXECUTORS
+
+ envsubst < "$HIVE_HOME/conf/llap-daemon-site.xml.template" >
"$HIVE_HOME/conf/llap-daemon-site.xml"
+
+ export LLAP_DAEMON_LOG_DIR="${LLAP_DAEMON_LOG_DIR:-/tmp/llapDaemonLogs}"
+ export LLAP_DAEMON_TMP_DIR="${LLAP_DAEMON_TMP_DIR:-/tmp/llapDaemonTmp}"
+ export LOCAL_DIRS="${LOCAL_DIRS:-/tmp/llap-local}"
+ mkdir -p "${LLAP_DAEMON_LOG_DIR}" "${LLAP_DAEMON_TMP_DIR}" "${LOCAL_DIRS}"
+
+ # runLlapDaemon.sh expects jars under ${LLAP_DAEMON_HOME}/lib.
+ # In this image, LLAP jars are under ${HIVE_HOME}/lib.
+ export LLAP_DAEMON_HOME="${LLAP_DAEMON_HOME:-$HIVE_HOME}"
+ export LLAP_DAEMON_CONF_DIR="${LLAP_DAEMON_CONF_DIR:-$HIVE_CONF_DIR}"
+ export
LLAP_DAEMON_USER_CLASSPATH="${LLAP_DAEMON_USER_CLASSPATH:-$TEZ_HOME/*:$TEZ_HOME/lib/*:$HADOOP_HOME/share/hadoop/common/*:$HADOOP_HOME/share/hadoop/common/lib/*:$HADOOP_HOME/share/hadoop/yarn/*:$HADOOP_HOME/share/hadoop/yarn/lib/*:$HADOOP_HOME/share/hadoop/hdfs/*:$HADOOP_HOME/share/hadoop/hdfs/lib/*:$HADOOP_HOME/share/hadoop/mapreduce/*:$HADOOP_HOME/share/hadoop/mapreduce/lib/*}"
+
+ JAVA_ADD_OPENS=(
+ "--add-opens=java.base/java.lang=ALL-UNNAMED"
+ "--add-opens=java.base/java.util=ALL-UNNAMED"
+ "--add-opens=java.base/java.io=ALL-UNNAMED"
+ "--add-opens=java.base/java.net=ALL-UNNAMED"
+ "--add-opens=java.base/java.nio=ALL-UNNAMED"
+ "--add-opens=java.base/java.util.concurrent=ALL-UNNAMED"
+ "--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED"
+ "--add-opens=java.base/java.util.regex=ALL-UNNAMED"
+ "--add-opens=java.base/java.lang.reflect=ALL-UNNAMED"
+ "--add-opens=java.sql/java.sql=ALL-UNNAMED"
+ "--add-opens=java.base/java.text=ALL-UNNAMED"
+ "-Dnet.bytebuddy.experimental=true"
+ )
+ for opt in "${JAVA_ADD_OPENS[@]}"; do
+ if [[ " ${LLAP_DAEMON_OPTS:-} " != *" ${opt} "* ]]; then
+ LLAP_DAEMON_OPTS="${LLAP_DAEMON_OPTS:-} ${opt}"
+ fi
+ done
+ export LLAP_DAEMON_OPTS
+
+ if [[ -n "${LLAP_EXTRA_OPTS:-}" ]]; then
+ export LLAP_DAEMON_OPTS="${LLAP_DAEMON_OPTS:-} ${LLAP_EXTRA_OPTS}"
Review Comment:
We can remove export from L119 `export LLAP_DAEMON_OPTS` and move L116 which
just exporting after this 2nd if stmt?
```
for opt in "${JAVA_ADD_OPENS[@]}"; do
if [[ " ${LLAP_DAEMON_OPTS:-} " != *" ${opt} "* ]]; then
LLAP_DAEMON_OPTS="${LLAP_DAEMON_OPTS:-} ${opt}"
fi
done
if [[ -n "${LLAP_EXTRA_OPTS:-}" ]]; then
LLAP_DAEMON_OPTS="${LLAP_DAEMON_OPTS:-} ${LLAP_EXTRA_OPTS}"
fi
export LLAP_DAEMON_OPTS
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
