deniskuzZ commented on code in PR #6379:
URL: https://github.com/apache/hive/pull/6379#discussion_r3001096200
##########
itests/hive-jmh/src/main/java/org/apache/hive/benchmark/ql/exec/KryoBench.java:
##########
@@ -123,7 +123,7 @@ public static MapWork mockMapWork(String tableName, int
partitions,
tblProps.put("serialization.lib", OrcSerde.class.getName());
tblProps.put("columns", columnNames.toString());
tblProps.put("columns.types", columnTypes.toString());
- TableDesc tbl = new TableDesc(OrcInputFormat.class, OrcOutputFormat.class,
tblProps);
+ TableDesc tbl = new TableDesc(OrcInputFormat.class, OrcOutputFormat.class,
tblProps, null);
Review Comment:
could we keep the 3arg constructor to avoid passing nulls from the callers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
