Neer393 commented on code in PR #6379:
URL: https://github.com/apache/hive/pull/6379#discussion_r2974611131
##########
llap-common/src/protobuf/LlapDaemonProtocol.proto:
##########
@@ -233,10 +233,11 @@ message SetCapacityRequestProto {
message SetCapacityResponseProto {
}
-// Used for proactive eviction request. Must contain one DB name, and
optionally table information.
+// Used for proactive eviction request. Must contain a DB name, catalog name,
and optionally table information.
message EvictEntityRequestProto {
required string db_name = 1;
repeated TableProto table = 2;
+ required string catalog_name = 3;
Review Comment:
@zhangbutao isn't this request `EvictEntityRequestProto` for internal
consumption only ? If yes then why do we need to make it optional ? Making it
required and made changes at the callers shouldn't break any backward
compatibility right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
