gemmellr commented on PR #5136: URL: https://github.com/apache/activemq-artemis/pull/5136#issuecomment-2278288455
Looks good overall, but I did spot an issue with handling of the data dir during upgrade. I've worked up a fix but still need to look into some testing changes, as I think the Upgrade tests should have some additional checks for the new additions, and in particular definitely need updated to ensure they cover the problematic path I found/fixed which they dont yet. Will convert to draft for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
