brusdev commented on code in PR #5136: URL: https://github.com/apache/activemq-artemis/pull/5136#discussion_r1709367239
########## docs/user-manual/versions.adoc: ########## @@ -309,7 +324,7 @@ Most existing customisations to the old configuration files and scripts will be As such you should compare the old configuration files with the refreshed ones and then port any missing customisations you may have made as necessary. The upgrade command itself will copy the older files it changes to an `old-config-bkp.` folder within the instance directory. -Similarly, if you had customised the old `logging.properties` file you may need to prepare analogous changes for the new `log4j2.properties` file. +Similarly, if you had customised the old `logging.properties` file you may need to prepare analogous changes for the new `log4j2.properties` and `log4j2-utility.properties` files. Review Comment: I agree with you, I'll revert this change. ########## docs/migration-guide/_configuration.adoc: ########## @@ -24,11 +24,13 @@ The main configuration file is `etc/broker.xml`. Similarly to ActiveMQ's `conf/activemq.xml`, this is where you configure most of the aspects of the broker, like connector ports, destination names, security policies, etc. We will go through this file in details in the following articles. -The `etc/artemis.profile` file is similar to the `bin/env` file in ActiveMQ. -Here you can configure environment variables for the broker, mostly regular JVM args related to SSL context, debugging, etc. +The `etc/artemis.profile` and `etc/artemis-utility.profile` files are similar to the `bin/env` file in ActiveMQ. +In the `etc/artemis.profile` you can configure environment variables for the broker started by executing the `run` command, mostly regular JVM args related to SSL context, debugging, etc. +In the `etc/artemis-utility.profile` file you can configure environment variables for all CLI commands other than run, mostly regular JVM args related to SSL context, debugging, etc. There's not much difference in logging configuration between two brokers, so anyone familiar with Java logging systems in general will find herself at home here. -The `etc/log4j-config.properties` file is where it's all configured. +The `etc/log4j.properties` file is where it's all configured for the broker. +The `etc/log4j-utility.properties` file is where it's all configured for all CLI commands other than run. Review Comment: Good catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
