On Sat, May 4, 2019 at 10:28 PM Junio C Hamano <gits...@pobox.com> wrote:
>
> Jeff King <p...@peff.net> writes:
>
> > I think spatch is smart enough not to hit the same header multiple
> > times. But the problem is that we invoke it once per file, so it
> > actually processes cache.h many times. That's slow, but also produces
> > bogus patches.
>
> Yes, I've seen this and was a bit irritated myself, but not enough
> to do something about it myself, yet.
> >
> > Jacob Keller's patches to collapse this to a single invocation do fix it
> > (and I've used them selectively in the past rather than cleaning up the
> > resulting patch manually ;) ).
>
> Ah, that is nice to know.  Do we want to resurrect it?

I remember deciding that the memory cost trade off was too high back then.

Thanks,
Jake

Reply via email to