Hi All,
I'm recently testing jdbcconfig (on geoserver 2.10, 2.9, 2,8), and I discover 
an interesting thing related workspaces remove function: it is called twice!

At beginning, I thought it was a bug of jdbcconfig, but today I got a confirm 
that two calls are in geoserver code.

To verify that, is enough to add a 

System.out.println("Removing Workspace"); 

in CatalogImpl.java (package org.geoserver.catalog.impl) at line 1212, compile 
and deploy.
After that, run application server (tomcat 8 for me), create a workspace and 
remove that. On catalina.out, you should see the message twice. 

Using geoserver, this is not a bug, but in jdbcconfig there is 

findObjectId(...)

at line 592 of ConfigDatabase.java, that fails on the second call, because 
there isn't the workspace.

Before proposing a patch, I'd like to understand why there are two calls to 
remove method (may be there's a good reason, but actually I can't see it). 
Depending on it, which idea is better: remove duplicated call or allow 
removing not existing workspaces without generating an exception. 

Cheers.

.Federico C Guizzardi
>_
abstract.it 
...............................................................................
Registro Imprese di Napoli 788429 / Cap. Soc. 10.000 Euro I.V. Avvertenze 
Legali - D. Lgs. 196/03 Tutela dei dati personali. Le informazioni contenute 
in questo messaggio e in ogni eventuale allegato sono riservate e ne รจ vietata 
ogni forma di diffusione. Se avete ricevuto questa comunicazione per errore, 
Vi preghiamo di informare immediatamente il mittente del messaggio e di 
eliminare l'e-mail.

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
_______________________________________________
Geoserver-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-users

Reply via email to