On 11/29/2016 03:46 AM, Michał Górny wrote: > On Mon, 28 Nov 2016 06:42:44 -0500 > Mike Pagano <mpag...@gentoo.org> wrote: > >> On 11/27/2016 09:06 PM, Mike Gilbert wrote: >>> On Sun, Nov 27, 2016 at 7:23 PM, Mike Pagano <mpag...@gentoo.org> wrote: >>>> If kernel-2_src_unpack() is called in EAPI6, epatch_user() function >>>> inherited from eutils.eclass is undefined. >>>> See bug #579188 >>> >>> kernel-2.eclass currently calls die in global scope for EAPI 6, so >>> this change has no real effect. >>> >>> I would suggest modernizing the eclass before allowing it to be used >>> with EAPI 6. For example, patches should be applied in src_prepare, >>> not src_unpack. >>> >> >> Is this change not a step in the right direction? Or should it just be >> one big bang? >> All or nothing? > > While I don't mean incremental changes, I'd really prefer if they made > any sense. Calling eapply_user in src_unpack() is invalid, per PMS: > > | In EAPIs where it is supported, eapply_user must be called once > | in the src_prepare phase. >
Your last sentence is constructive criticism. I'll fix this. -- Mike Pagano Gentoo Developer - Kernel Project Gentoo Sources - Lead E-Mail : mpag...@gentoo.org GnuPG FP : 52CC A0B0 F631 0B17 0142 F83F 92A6 DBEC 81F2 B137 Public Key : http://http://pgp.mit.edu/pks/lookup?search=0x92A6DBEC81F2B137&op=index
signature.asc
Description: OpenPGP digital signature
