On Tue, May 10, 2016 at 10:19 PM, Mike Gilbert <flop...@gentoo.org> wrote:
> On Tue, May 10, 2016 at 9:42 PM, Mike Gilbert <flop...@gentoo.org> wrote:
>>> Anywhere that you need addpredict() it also seems reasonable. The
>>> v4l-dvb-saa716x ebuilds use "${ROOT}/usr/src/linux/" where EPREFIX would
>>> not be a good replacement.
>>
>> Nah, usually addpredict is dealing with stuff in the system that is
>> performing the build. Sandboxed phases should never be looking at
>> ROOT.
>>
>> Those ebuilds should probably do addpredict /usr/src/linux instead.
>
> Oh, I see. It's compiling kernel modules based on linux sources
> installed in ROOT. Given the definition in PMS, I would say that's
> undefined behavior at best.
>
> I think SYSROOT might be a better fit here.
Actually, given the linux-mod eclass usage, it seems like
${KERNEL_DIR} would be a better choice than ${ROOT}/usr/src/linux.
It's also problematic that linux-info.eclass refers to ROOT in global
scope, but that's a separate bug/discussion.
