On Friday, February 06, 2015 12:54:26 PM hasufell wrote:
> Luke Dashjr:
> > On Friday, February 06, 2015 2:10:31 AM hasufell wrote:
> >> Why does it not use git-r3?
> >
> > I just looked into this, and I don't see a way to get git-r3 to use the
> > same repositories already cloned for previous versions. What is the
> > standard practice for ebuilds already using git-2?
>
> Why is that important? git-r3 has shallow clones.
But it doesn't use them by default...
Also, it seems that it can't use a common repository for different remotes.
While right now, we're only supporting git master, in the past we've also had
times we supported stable branches, which are usually kept separate.
> >> autoreconf is not reliable and we know that it sometimes unpredictably
> >> fails. Running it unconditionally is a bit strong, no?
> >
> > What should be used instead, to generate configure etc?
>
> I was implicitly asking if there are never any configure scripts already
> generated and if all patches touch the build system.
We're pulling the sources direct from GitHub's automatically generated
tarballs, which never have configure generated in them.
> >> bitcoincore_conf() looks like it could make use of 'usex' and
> >> 'use_enable' instead of those difficult to read if-else conditions.
> >
> > These will give QA issues for ebuilds that don't have the applicable USE
> > flag available in IUSE.
>
> if_iusex() { use_if_iuse "$1" && echo "${2-yes}$4" || echo "${3-no}$5" ; }
>
> if_iuse_enable() {
> local UWORD=${2:-$1}
> local UE_SUFFIX=${3+=$3}
>
> if use_if_iuse $1; then
> echo "--enable-${UWORD}${UE_SUFFIX}"
> else
> echo "--disable-${UWORD}"
> fi
> }
This would work for 'test' and 'wallet', but uses more lines of code than they
do as-is..
> Another thing I just found:
>
> # @FUNCTION: in_iuse
> [...]
> # Note that this function should not be used in the global scope.
>
> Seems you use it in global scope.
Odd. It looks like it should work fine... and there isn't really any way
around it AFAIK other than wrapping it in a function and calling that from
global scope.
Luke
