On 15/03/11 22:25, Tomáš Chvátal wrote: > Dne 15.3.2011 21:51, justin napsal(a): >> Donnie pointed out, that it might be clever to attach what I want to >> have reviewed. So here it is. > >> justin > EAPI CAN'T BE DEFINED IN ECLASS! > this should be craved into stones :)
I didn't see this mentioned anywhere in the docs. But okay, this is fixable. > > Some whitespace is funny. I love funny whitespaces. > > look on XFCONF_AUTORECONF or XORG_AUTORECONF variable, just create > EBO_AUTORECONF with yes by default and handle it correctly. Thanks for that hint. I will change it accordingly. > > i am seriously hurt by $(use_enable amd64 64) Where is the problem? The purpose of the eclass is not to repeat the same code 20 times. Why can't this be here? > > why are not those functions exported for embassy ebuild? Just a Meta ebuild to install all modules (emabassy-*). > > Cheers > > Tom thanks justin
signature.asc
Description: OpenPGP digital signature
