On Fri, 20 Jul 2007 11:52:02 +0200
Michael Hanselmann <[EMAIL PROTECTED]> wrote:
> Hello Benedikt
>
> On Fri, Jul 13, 2007 at 01:37:11PM +0200, Benedikt Boehm wrote:
> > It is basically netqmail split into much smaller chunks so they can
> > be reused by other qmail variants as well.
>
> Okay, I looked through it and found some things which need
> reconsideration. I agree that user creation and such things can be
> easily done in an eclass. However, functions like qmail_src_unpack
> should be done in the ebuild. Putting them in an eclass and just doing
> "if (a) { … } else if (b) { … }" makes it harder to understand and
> unneccessarily complicated.
I absolutely agree here, it is just too ugly.
> qmail_base_install should be split in
> smaller functions, maybe with callbacks (if possible in bash).
There is now qmail_mini_install (called by every qmail ebuild) and
qmail_{full,man,sendmail}_install for the rest of a full blown install.
I'm not sure what you mean with "callbacks" here, maybe you can
elaborate?
> In the
> end the ebuild shouldn't contain any package-specific code. Can you
> look into it again?
The qmail_*_install changes are already in my overlay, i will look into
removing the unpack stuff from the eclass together with some
DEPEND/IUSE cleanups to get rid of qmail_mini() tomorrow.
HTH,
Bene
--
[EMAIL PROTECTED] mailing list
