Hello Benedikt On Fri, Jul 13, 2007 at 01:37:11PM +0200, Benedikt Boehm wrote: > It is basically netqmail split into much smaller chunks so they can be > reused by other qmail variants as well.
Okay, I looked through it and found some things which need reconsideration. I agree that user creation and such things can be easily done in an eclass. However, functions like qmail_src_unpack should be done in the ebuild. Putting them in an eclass and just doing "if (a) { … } else if (b) { … }" makes it harder to understand and unneccessarily complicated. qmail_base_install should be split in smaller functions, maybe with callbacks (if possible in bash). In the end the ebuild shouldn't contain any package-specific code. Can you look into it again? Greets, Michael -- http://hansmi.ch/
pgpN5aX0DMOPJ.pgp
Description: PGP signature