Eli Schwartz <eschwa...@gentoo.org> writes:
> On 3/14/25 11:31 AM, orbea wrote:
>> Changing it as you suggested I think would be significantly more
>> complicated and would require refactoring the eclass.
>
>
> Yes, it's unfortunately the type of thing that would be a somewhat
> involved change. :(
>
>
>> However I wonder if my patch still has merit since in the case of
>> slibtoolize it only needs to be set for aclocal and not all the other
>> tools that are executed during eautoreconf? Although including it
>> everywhere doesn't seem to cause any problems yet either.
>
>
> Not sure I understand what you mean. :) This is only used for aclocal
> either way.
>
> And your patch is I think fundamentally correct.
>
> The externally injected AT_SYS_M4DIR documented in the wiki is an
> understandable hack but nonetheless a *hack* and we should move away
> from it by treating slibtool the same as our generic aclocal handling.
>
> That's true even though I'd *also* like to see AT_SYS_M4DIR unbroken. It
> is nominally for "cases such as slibtool but where the user / system
> integrator has added it in ways ::gentoo cannot predict", but given
> slibtool is packaged in ::gentoo it is eminently reasonable to just
> include it directly in the list.
>
> ...
>
> Hmm, now that makes me think. Sam, maybe we can fix AT_SYS_M4DIR by
> making it not get passed as -I but instead get concatenated into
> ${T}/aclocal/dirlist
I agree, and I think it was an oversight to not do that when introducing
it...
Eli or orbea, do you want to send a patch for that (on top of this one)?
